Skip to content

refac: clean up piecewise module #641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
FBumann merged 26 commits into from
Apr 1, 2026
+418 −288
Merged

refac: clean up piecewise module #641

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
cc79224
refac: use _to_linexpr in tangent_lines instead of manual dispatch
FBumann Apr 1, 2026
2c7d098
refac: rename _validate_xy_points to _validate_breakpoint_shapes
FBumann Apr 1, 2026
dd8d283
refac: clean up duplicate section headers in piecewise.py
FBumann Apr 1, 2026
b9945e5
refac: convert expressions once in _broadcast_points
FBumann Apr 1, 2026
9fe9671
refac: remove unused _compute_combined_mask
FBumann Apr 1, 2026
2c8dfdc
refac: validate method early, compute trailing_nan_only once
FBumann Apr 1, 2026
0b3155b
refac: deduplicate stacked mask expansion in _add_continuous_nvar
FBumann Apr 1, 2026
607f503
refac: remove redundant isinstance guards in tangent_lines
FBumann Apr 1, 2026
2712b48
refac: rename _extra_coords to _var_coords_from with explicit exclude…
FBumann Apr 1, 2026
2716267
refac: clarify transitive validation in breakpoint shape check
FBumann Apr 1, 2026
ccb4e8f
refac: remove skip_nan_check parameter
FBumann Apr 1, 2026
3ce1377
refac: remove unused PWL_AUX/LP/LP_DOMAIN constants
FBumann Apr 1, 2026
f5d33bf
refac: always return link constraint from incremental path
FBumann Apr 1, 2026
ace5703
refac: split _add_continuous into _add_sos2 and _add_incremental
FBumann Apr 1, 2026
0af8bc2
refac: rename test classes to match current function names
FBumann Apr 1, 2026
ae73bc3
refac: use _stack_along_link for expression stacking
FBumann Apr 1, 2026
1ed2666
refac: use generic param names in _validate_breakpoint_shapes
FBumann Apr 1, 2026
3b608e4
refac: extract _to_seg helper in tangent_lines for rename+reassign pa…
FBumann Apr 1, 2026
9885b08
refac: extract _strip_nan helper for NaN filtering in slopes mode
FBumann Apr 1, 2026
1074303
refac: extract _breakpoints_from_slopes, add _to_seg docstring
FBumann Apr 1, 2026
a16ffb6
fix: resolve mypy errors in _strip_nan and _stack_along_link types
FBumann Apr 1, 2026
6641616
refac: remove duplicate slopes validation in breakpoints()
FBumann Apr 1, 2026
6e39138
refac: move _rename_to_segments to module level, fix extra blank line
FBumann Apr 1, 2026
30b0e68
test: add validation and edge-case tests for piecewise module
FBumann Apr 1, 2026
b110248
fix: resolve ruff and mypy errors
FBumann Apr 1, 2026
650811f
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Apr 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion doc/piecewise-linear-constraints.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,6 @@ API
method="auto", # "auto", "sos2", or "incremental"
active=None, # binary variable to gate the constraint
name=None, # base name for generated variables/constraints
skip_nan_check=False,
)

Creates auxiliary variables and constraints that enforce all expressions
Expand Down
3 changes: 0 additions & 3 deletions linopy/constants.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,9 +46,6 @@
PWL_FILL_SUFFIX = "_fill"
PWL_BINARY_SUFFIX = "_binary"
PWL_SELECT_SUFFIX = "_select"
PWL_AUX_SUFFIX = "_aux"
PWL_LP_SUFFIX = "_lp"
PWL_LP_DOMAIN_SUFFIX = "_lp_domain"
PWL_INC_BINARY_SUFFIX = "_inc_binary"
PWL_INC_LINK_SUFFIX = "_inc_link"
PWL_INC_ORDER_SUFFIX = "_inc_order"
Expand Down
Loading