Closed
Conversation
xarray 2026.4.0 no longer allows passing a Dataset to the Dataset() constructor. Remove redundant Dataset() wrappers around methods that already return a Dataset (transpose, assign_coords), and add an isinstance check in the parameters setter where the input may be either a Dataset or a Mapping. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
highspy 1.14.0 returns suboptimal solutions for modified MIP models, causing test_modified_model to fail across all platforms. Closes #651 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This reverts commit 5431186.
The `cls` parameter was typed as `type[GenericExpression]` but assigned concrete subclasses. Use `type[GenericExpression] | None` with a targeted type: ignore on the narrowing assignment, and add an assert to satisfy mypy at the call site. Closes #652 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #650
Datasetto theDataset()constructor (xarray GH11095)Dataset()wrappers aroundtranspose()andassign_coords()calls that already return aDatasetisinstancecheck inModel.parameterssetter where input may be either aDatasetor aMappingNote: Pre-existing CI failures unrelated to this change:
Test plan
🤖 Generated with Claude Code