Skip to content

fix: xarray 2026.4 Dataset-into-Dataset TypeError #657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
FBumann wants to merge 1 commit into from
Closed

fix: xarray 2026.4 Dataset-into-Dataset TypeError #657

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions linopy/expressions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,7 +284,7 @@ def sum(self, use_fallback: bool = False, **kwargs: Any) -> LinearExpression:
index.names = [str(col) for col in orig_group.columns]
index.name = GROUP_DIM
new_coords = Coordinates.from_pandas_multiindex(index, GROUP_DIM)
ds = xr.Dataset(ds.assign_coords(new_coords))
ds = ds.assign_coords(new_coords)

ds = ds.rename({GROUP_DIM: final_group_name})
return LinearExpression(ds, self.model)
Expand Down Expand Up @@ -391,8 +391,8 @@ def __init__(self, data: Dataset | Any | None, model: Model) -> None:
coeffs_vars_dict = {str(k): v for k, v in coeffs_vars.items()}
data = assign_multiindex_safe(data, **coeffs_vars_dict)

# transpose with new Dataset to really ensure correct order
data = Dataset(data.transpose(..., TERM_DIM))
# transpose to ensure correct dimension order
data = data.transpose(..., TERM_DIM)

# ensure helper dimensions are not set as coordinates
if drop_dims := set(HELPER_DIMS).intersection(data.coords):
Expand Down Expand Up @@ -2098,7 +2098,7 @@ def __init__(self, data: Dataset | None, model: Model) -> None:
raise ValueError(f"Size of dimension {FACTOR_DIM} must be 2.")

# transpose data to have _term as last dimension and _factor as second last
data = xr.Dataset(data.transpose(..., FACTOR_DIM, TERM_DIM))
data = data.transpose(..., FACTOR_DIM, TERM_DIM)
self._data = data

@property
Expand Down
4 changes: 3 additions & 1 deletion linopy/model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -359,7 +359,9 @@ def parameters(self, value: Dataset | Mapping) -> None:
"""
Set the parameters of the model.
"""
self._parameters = Dataset(value)
self._parameters = (
value.copy() if isinstance(value, Dataset) else Dataset(value)
)

@property
def solution(self) -> Dataset:
Expand Down