fix: as_dataarray treating multi-index levels as extra dims#659
Merged
FabianHofmann merged 3 commits intomasterfrom Apr 20, 2026
Merged
fix: as_dataarray treating multi-index levels as extra dims#659FabianHofmann merged 3 commits intomasterfrom
FabianHofmann merged 3 commits intomasterfrom
Conversation
When a scalar is broadcast against an xarray.Coordinates object with a pandas MultiIndex, dims were derived from coords.keys() which includes level names. Use coords.dims for Coordinates objects so the scalar is shaped to the actual dimensions only.
Assert coord names, values, and that level coords remain attached to the parent dim, so silent level-name leakage can't pass. Parametrize across scalar/array arg types and across Coordinates / dict / DataArray.coords inputs, plus an explicit-dims-wins case. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Collaborator
|
Nice catch — I added
I found the following bug, but declared it out of scope for now: |
FBumann
approved these changes
Apr 20, 2026
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Collaborator
Author
|
Thanks @FBumann ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request
When
as_dataarrayis given a scalar (np.number,int,float,bool,str, orlist) together with anxarray.Coordinatesobject whose underlying index is a pandasMultiIndex, it inferred dims fromcoords.keys(). That includes the level names, so a scalar withstationcoords containing levelsletter/numwas broadcast to shape(2, 2, 2)over('station', 'letter', 'num')instead of(2,)over('station',).coords.dimswhencoordsis anxarray.Coordinatesinstance so only real dimensions are used.np.numberandint | float | str | bool | listbranches ofas_dataarrayinto one, now that both need the same dim resolution.test_common.pycovering the scalar + multi-indexCoordinatescase.Checklist
doc.doc/release_notes.rstof the upcoming release is included.