docs: credit Felix Bumann in copyright, author, and pyproject maintainers#687
Merged
Conversation
Picks up Fabian's review comment on PR 681 (the copyright bump), adding the second contributor name. Updates both ``copyright`` and ``author`` in ``doc/conf.py`` so the docs footer and PDF metadata stay consistent, and updates the matching License line in ``doc/index.rst`` so the rendered License section doesn't drift from the footer. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
FBumann
changed the title
Adds a maintainers entry alongside the existing authors. By PEP 621 convention, authors records the original creators of a package and maintainers records ongoing contributors, so listing the new contributor under maintainers (rather than authors) reflects the package history accurately while still surfacing the credit on PyPI and in pip show linopy output. Fabian is duplicated into maintainers as well, because PEP 621 treats the maintainers list as the complete current set rather than a delta from authors -- listing only the new contributor would imply the original author is no longer maintaining the project. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
FBumann
force-pushed
the
docs/copyright-credit
branch
from
4c3fdcd to
e4a9473
Compare
FabianHofmann
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Mention Felix Bumann as an author/maintainer of linopy.
Changes
doc/conf.py— adds Felix Bumann tocopyrightandauthor.doc/index.rst— updates the matchingCopyright 2021-2026 Fabian Hofmannline in the License section.pyproject.toml— adds Felix Bumann as amaintainersentry alongside the existingauthors.Reasoning with Claude
Why both
copyrightandauthorin conf.py?Sphinx convention is to keep the two aligned:
copyrightrenders in the docs footer,authoris used in PDF builds and metadata. Updating only one would leave the footer crediting two people while the PDF title page still credits one.Why also
doc/index.rst?The License section there renders the same copyright statement to the user; touching only
conf.pywould leave the footer and the rendered License section out of sync.Why
maintainersand notauthorsin pyproject.toml?PEP 621 convention is that
authorsrecords the original creators of a package andmaintainersrecords ongoing contributors. Listing the new contributor undermaintainersreflects the package history accurately while still surfacing the credit on PyPI and inpip show linopyoutput.Why the
Hofmann2023JOSS BibTeX is left aloneThat citation block is for the published JOSS paper, not the codebase. The author list there reflects who's on the paper and should stay as-is.