Skip to content

Xpress 9.9+ backward compatibility and other updates #701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
FabianHofmann merged 3 commits into from
May 20, 2026
+99 −26
Merged

Xpress 9.9+ backward compatibility and other updates #701

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ddcb712
fix(xpress): restore 9.8+ API backward compat and fix deprecation war…
brunoficoxpress May 19, 2026
63fa816
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] May 19, 2026
9268583
fix(xpress): common kwargs, readProb compat, getDuals fallback for pr…
brunoficoxpress May 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
125 changes: 99 additions & 26 deletions linopy/solvers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2180,34 +2180,76 @@ def _build_solver_model(
entind = None
coltype = None

problem.loadproblem(
objcoef = np.asarray(M.c, dtype=float)
has_q = objqcol1 is not None
has_int = coltype is not None
base_kwargs: dict[str, Any] = dict(
probname="linopy",
rowtype=rowtype,
rhs=rhs,
rng=None,
objcoef=np.asarray(M.c, dtype=float),
objcoef=objcoef,
start=start,
collen=None,
rowind=rowind,
rowcoef=rowcoef,
lb=lb,
ub=ub,
objqcol1=objqcol1,
objqcol2=objqcol2,
objqcoef=objqcoef,
qrowind=None,
nrowqcoefs=None,
rowqcol1=None,
rowqcol2=None,
rowqcoef=None,
coltype=coltype,
entind=entind,
limit=None,
settype=None,
setstart=None,
setind=None,
refval=None,
)
try: # Try new API first (Xpress 9.8+)
if has_q and has_int:
problem.loadMIQP(
Comment thread
brunoficoxpress marked this conversation as resolved.
**base_kwargs,
objqcol1=objqcol1,
objqcol2=objqcol2,
objqcoef=objqcoef,
coltype=coltype,
entind=entind,
)
elif has_q:
problem.loadQP(
**base_kwargs,
objqcol1=objqcol1,
objqcol2=objqcol2,
objqcoef=objqcoef,
)
elif has_int:
problem.loadMIP(
**base_kwargs,
coltype=coltype,
entind=entind,
)
else:
problem.loadLP(**base_kwargs)
except AttributeError: # Fallback to old API
problem.loadproblem(
probname="linopy",
rowtype=rowtype,
rhs=rhs,
rng=None,
objcoef=objcoef,
start=start,
collen=None,
rowind=rowind,
rowcoef=rowcoef,
lb=lb,
ub=ub,
objqcol1=objqcol1,
objqcol2=objqcol2,
objqcoef=objqcoef,
qrowind=None,
nrowqcoefs=None,
rowqcol1=None,
rowqcol2=None,
rowqcoef=None,
coltype=coltype,
entind=entind,
limit=None,
settype=None,
setstart=None,
setind=None,
refval=None,
)

if model.objective.sense == "max":
problem.chgobjsense(xpress.maximize)
Expand All @@ -2218,10 +2260,20 @@ def _build_solver_model(
)
vnames = print_variable(M.vlabels)
if vnames:
problem.addnames(xpress_Namespaces.COLUMN, vnames, 0, len(vnames) - 1)
try: # Try new API first (Xpress 9.8+)
problem.addNames(
xpress_Namespaces.COLUMN, vnames, 0, len(vnames) - 1
)
except AttributeError: # Fallback to old API
problem.addnames(
xpress_Namespaces.COLUMN, vnames, 0, len(vnames) - 1
)
cnames = print_constraint(M.clabels)
if cnames:
problem.addnames(xpress_Namespaces.ROW, cnames, 0, len(cnames) - 1)
try: # Try new API first (Xpress 9.8+)
problem.addNames(xpress_Namespaces.ROW, cnames, 0, len(cnames) - 1)
except AttributeError: # Fallback to old API
problem.addnames(xpress_Namespaces.ROW, cnames, 0, len(cnames) - 1)

if model.variables.sos:
for var_name in model.variables.sos:
Expand Down Expand Up @@ -2285,7 +2337,10 @@ def _run_file(
sense = read_sense_from_problem_file(problem_fn)

m = xpress.problem()
m.read(path_to_string(problem_fn))
try: # Try new API first
m.readProb(path_to_string(problem_fn))
except AttributeError: # Fallback to old API
m.read(path_to_string(problem_fn))

return self._solve(
m,
Expand Down Expand Up @@ -2321,25 +2376,40 @@ def _solve(
m.setControl(self.solver_options)

if log_fn is not None:
m.setlogfile(path_to_string(log_fn))
try: # Try new API first
m.setLogFile(path_to_string(log_fn))
except AttributeError: # Fallback to old API
m.setlogfile(path_to_string(log_fn))

if warmstart_fn is not None:
m.readbasis(path_to_string(warmstart_fn))
try: # Try new API first
m.readBasis(path_to_string(warmstart_fn))
except AttributeError: # Fallback to old API
m.readbasis(path_to_string(warmstart_fn))

m.optimize()

if m.attributes.solvestatus == xpress.enums.SolveStatus.STOPPED:
m.postsolve()
try: # Try new API first
m.postSolve()
except AttributeError: # Fallback to old API
m.postsolve()

if basis_fn is not None:
try:
m.writebasis(path_to_string(basis_fn))
try: # Try new API first
m.writeBasis(path_to_string(basis_fn))
except AttributeError: # Fallback to old API
m.writebasis(path_to_string(basis_fn))
except (xpress.SolverError, xpress.ModelError) as err: # pragma: no cover
logger.info("No model basis stored. Raised error: %s", err)

if solution_fn is not None:
try:
m.writebinsol(path_to_string(solution_fn))
try: # Try new API first
m.writeBinSol(path_to_string(solution_fn))
except AttributeError: # Fallback to old API
m.writebinsol(path_to_string(solution_fn))
except (xpress.SolverError, xpress.ModelError) as err: # pragma: no cover
logger.info("Unable to save solution file. Raised error: %s", err)

Expand All @@ -2365,7 +2435,10 @@ def get_solver_solution() -> Solution:
if m.attributes.rows == 0:
dual = np.array([], dtype=float)
else:
dual_values = np.asarray(m.getDual(), dtype=float)
try: # getDuals introduced in 9.5; fallback for 9.4
dual_values = np.asarray(m.getDuals(), dtype=float)
except AttributeError:
dual_values = np.asarray(m.getDual(), dtype=float)
if from_file:
dual = _solution_from_names(
dual_values,
Expand Down
Loading