-
Notifications
You must be signed in to change notification settings - Fork 19
use higher lifetime only for existing German gas CHPs #90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This reverts commit ea88245.
cpschau
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good to me! Only two comments:
- A comment that states assumptions for 40 year lifetime might be helpful. Making it a configurable setting would be the icing on the cherry on the cake.
- Do we want to keep the Changelog? If yes we would need another entry.
I am not entirely sure about the fill value of 40 years, as it sounds quite optimistic for me comparing it to other sources (DEA assumes 25 years). Taking a look into the data it also seems as if there were a couple of smaller CHP plants that had a way shorter lifetime than 25 years. Not sure if they were actually decommissioned or maybe re-registered with a different ID.
cpschau
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Feel free to leave the refactoring of params call to a dedicated PR.
* use higher lifetime only for existing German gas CHPs * actually use adjusted lifetime when asset is created * Revert "disable chps from prepare_sector_network" This reverts commit ea88245. * use pivot_table weighted by capacity to determine lifetimes * remove old comments * remove unused dropna * make NA values for existing gas CHPs a config setting * add changelog note * use all lower case for config
Final Summary of changes:
the issue was more complex than I thought. This were some to dos:
Original issue description
During the validation of the electricity sector we noticed that there were not enough gas CHPs in the data, see PyPSA/pypsa-ariadne#285
This is partially because the DateOut of many CHPs in german_chps.csv is missing, s.t. a default lifetime of 25 years was assumed. However, as some manual checks @JulianGeis revealed, many of the CHPs remain in operation after 25 years-
To improve the representation of these assets the lifetime of gas CHPs was extended to 40 years. However, the way it was done, this also affects newly built gas CHPs, reducing their annuities. This PR keeps the lifetime extension for existing assets, but removes it for new ones.
Before asking for a review for this PR make sure to complete the following checklist:
ariadne_allcompletes without errorsexport_ariadne_variableshas been adapted to the changesChangelog.mdmainhas been merged into the PRYYYYMMDDdescriptive_title