Skip to content

Conversation

@iraedeus
Copy link
Collaborator

No description provided.

@iraedeus iraedeus force-pushed the iraedeus/new-distributions branch from 95b0ed5 to 224e2e6 Compare July 7, 2025 16:26
@iraedeus iraedeus requested a review from Copilot July 7, 2025 16:45
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces four new probability distributions—Uniform, Beta, Cauchy, and Pareto Type I—into the mpest library.

  • Added model implementations and corresponding unit tests for each new distribution.
  • Updated mixture‐generation utilities and model registry to include the new distributions.
  • Adjusted project configuration and documentation to reflect the additions.

Reviewed Changes

Copilot reviewed 38 out of 42 changed files in this pull request and generated no comments.

Show a summary per file
File Description
mpest/models/uniform.py Added Uniform distribution model
mpest/models/beta.py Added Beta distribution model
mpest/models/cauchy.py Added Cauchy distribution model
mpest/models/pareto.py Added Pareto distribution model
tests/models/test_uniform.py, test_beta.py, test_cauchy.py, test_pareto.py Added tests for the new distributions
experimental_env/mixture_generators/utils.py Updated standard and uniform parameter generators
mpest/models/init.py Registered the new models in ALL_MODELS
experimental_env/analysis/analyze_summarizers/error_summarizer.py Modified error summarizer logic
experimental_env/experiment/experiment_executors/random_executor.py Adjusted seeding for random mixture executor
experimental_env/experiment/experiment_executors/standart_executor.py Adjusted seeding for standard mixture executor
pyproject.toml Updated project metadata, dependencies, and tooling exclusions
Comments suppressed due to low confidence (5)

tests/models/test_beta.py:51

  • [nitpick] This variable is instantiating a Beta model but named pareto_model; rename it to beta_model for clarity.
        pareto_model = Beta()

experimental_env/analysis/analyze_summarizers/error_summarizer.py:46

  • Median is computed on the unsorted errors list; you should sort errors before computing the median.
        median = errors[len(errors) // 2]

experimental_env/experiment/experiment_executors/random_executor.py:22

  • By removing the seed argument (self._seed) you lose reproducibility; pass the executor's seed into RandomDatasetGenerator.
                RandomMixtureGenerator().create_mixture(models),

experimental_env/experiment/experiment_executors/standart_executor.py:22

  • Dropping the seed parameter here breaks deterministic behavior; it should be StandartMixtureGenerator(self._seed).
                StandartMixtureGenerator().create_mixture(models),

pyproject.toml:8

  • [nitpick] Poetry expects an SPDX license identifier (e.g. MIT) rather than the filename; consider using license = "MIT" and license-file for the path.
license = "LICENSE"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's need to be a MixtureDistribution, not a Misture

@iraedeus iraedeus requested a review from vkutuev July 11, 2025 20:17
@iraedeus
Copy link
Collaborator Author

Closed, split into three separate pull requests: PR1, PR2, PR3

@iraedeus iraedeus closed this Jul 17, 2025
@iraedeus iraedeus deleted the iraedeus/new-distributions branch July 17, 2025 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants