Skip to content

[Refactoring] E step code duplicate #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 12, 2025
Merged

[Refactoring] E step code duplicate #30

merged 5 commits into from
Jul 12, 2025

Conversation

@MaxPastukhov15
Copy link
Contributor

@MaxPastukhov15 MaxPastukhov15 commented Jul 12, 2025 •
edited
Loading

  1. Made BayesEStep work with LMomentsMStep and LikelihoodMStep work as before when there were IndicatorEStep
  2. So added flags for sorting in LMomentEStep and BayesEStep
  3. Decided to return instead of active_sample new_priors , cause I didn't see any dependecies in LikelihoodMStep(active_samples goes into new_problem as one of parameters)
  4. Decided keep sorting in BayesEStep cause otherwise it losses a lot of accuraccy

Closes #19

@MaxPastukhov15
refactor: merged two classes BayesEStep and IndicatorEStep into one B…
43e9b7a 
…ayesEStep and made this class work with both MStep classes
@MaxPastukhov15 MaxPastukhov15 requested a review from iraedeus July 12, 2025 07:29
iraedeus
iraedeus requested changes Jul 12, 2025
View reviewed changes
@MaxPastukhov15 MaxPastukhov15 requested a review from iraedeus July 12, 2025 16:32
@MaxPastukhov15 MaxPastukhov15 self-assigned this Jul 12, 2025
@iraedeus iraedeus merged commit f327287 into PySATL:main Jul 12, 2025
3 checks passed
@iraedeus iraedeus mentioned this pull request Jul 16, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iraedeus iraedeus iraedeus approved these changes

Assignees

@MaxPastukhov15 MaxPastukhov15

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Refactoring] E step code duplicate

2 participants

@MaxPastukhov15 @iraedeus