Skip to content

Fix #76#78

Merged
Tymewalk merged 3 commits intomasterfrom
fixBasicTest
Sep 11, 2016
Merged

Fix #76#78
Tymewalk merged 3 commits intomasterfrom
fixBasicTest

Conversation

@Tymewalk
Copy link
Copy Markdown
Member

Will fix #76.

For debugging
@Tymewalk Tymewalk self-assigned this Sep 11, 2016
@BookOwl
Copy link
Copy Markdown
Member

BookOwl commented Sep 11, 2016

Just remove the prints and rename the vars and we should be able to merge.

@BookOwl BookOwl added this to the v0.3.0 milestone Sep 11, 2016
@Tymewalk
Copy link
Copy Markdown
Member Author

@BookOwl Yep, the inheritance worked!

@BookOwl
Copy link
Copy Markdown
Member

BookOwl commented Sep 11, 2016

Great!

@BookOwl
Copy link
Copy Markdown
Member

BookOwl commented Sep 11, 2016

Is this ready to merge?

@Tymewalk
Copy link
Copy Markdown
Member Author

@BookOwl No. Still need to rename vars with their _var equivalents

But then I'll test and then yes.

Still requires testing.
@Tymewalk Tymewalk merged commit 118063e into master Sep 11, 2016
@Tymewalk
Copy link
Copy Markdown
Member Author

Just fixed it. All variables now have underscores where they should be, preventing any other glitches. basicTest.py still works, so everything's fine 🎊

@Tymewalk Tymewalk mentioned this pull request Sep 11, 2016
@BookOwl BookOwl deleted the fixBasicTest branch September 12, 2016 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

basicTest.py doesn't work in Python2

2 participants