Add table prefix support for SQLAlchemy dataset store #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement configurable table prefix to allow prefixing all database tables.
This enables multiple environments (dev, staging, prod) to share the same
database or better organize tables.
Configuration example:
main:
metadata_url: "sqlite:///database.db"
metadata_options:
table_prefix: "prod_"
Changes:
- Add get_tables(table_prefix) factory function in tables.py
- Update SqlAlchemySessionProvider to accept and use table_prefix
- Update SqlAlchemyDatasetRepository to access tables via properties
- Add metadata_options config support in main.py
- Add end-to-end test for table prefix functionality
All table names and foreign key references are properly prefixed.
Fully backward compatible - existing configs work without changes.
koenvo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement configurable table prefix to allow prefixing all database tables.
This enables multiple environments (dev, staging, prod) to share the same
database or better organize tables.
Configuration example:
Changes:
All table names and foreign key references are properly prefixed.
Fully backward compatible - existing configs work without changes.