Redesign event log with proper separation of concerns#63
Merged
Conversation
Contributor
koenvo
commented
Mar 18, 2026
koenvo
commented
- Add EventLog class owning all event_log table access (write + fetch)
- EventLog.write() accepts domain events directly
- EventLog.fetch_batch() reconstructs and returns domain events
- EventLogSubscriber delegates to EventLog
- EventLogConsumer owns reader_state, uses EventLog for events
- Simplify tests to 4 focused cases
- Add EventLog class owning all event_log table access (write + fetch) - EventLog.write() accepts domain events directly - EventLog.fetch_batch() reconstructs and returns domain events - EventLogSubscriber delegates to EventLog - EventLogConsumer owns reader_state, uses EventLog for events - Simplify tests to 4 focused cases
- write() stores event.model_dump() so future event fields survive round-trip - fetch_batch() uses event_cls.model_validate() directly - Add test_consumer_only_processes_new_events
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.