Feat/subworkflows#29
Merged
JeanKaddour merged 30 commits intomainfrom Nov 29, 2024
Merged
Conversation
…put, and fixed input and dynamic output
…and output fields in nodeType
…e or unused outputs
JeanKaddour
reviewed
Nov 29, 2024
|
|
||
| """ | ||
|
|
||
| _SUPPORTED_NODE_TYPES = { |
Contributor
There was a problem hiding this comment.
yes, let's finally get rid of this!
JeanKaddour
approved these changes
Nov 29, 2024
| output_schema: Dict[str, str] = Field(default={"response": "str"}) | ||
|
|
||
|
|
||
| class BestOfNNode(EphemeralSubworkflowNode): |
Contributor
There was a problem hiding this comment.
could also consider using Temporary instead of Ephemeral for simplicity
Collaborator
Author
There was a problem hiding this comment.
While, other workflows are persisted in the DB, these ones are created at runtime and not stored anywhere.
I think "ephemeral" is a more apt term (and popular in software too) for such things, that are transient/not persistent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes