Skip to content

Bugfix/conditional node#69

Merged
JeanKaddour merged 6 commits intoperf/flowSlicev2from
bugfix/conditional-node
Dec 31, 2024
Merged

Bugfix/conditional node#69
JeanKaddour merged 6 commits intoperf/flowSlicev2from
bugfix/conditional-node

Conversation

@preet-bhadra
Copy link
Copy Markdown
Collaborator

@preet-bhadra preet-bhadra commented Dec 31, 2024

Important

Add Deepseek model support, fix typo, and improve node handling in frontend.

  • Backend:
    • Add DEEPSEEK_API_KEY to MODEL_PROVIDER_KEYS in key_management.py.
    • Add DEEPSEEK to LLMProvider and DEEPSEEK_CHAT to LLMModels in llm_utils.py.
  • Frontend:
    • Fix typo: rename setPredcessorNodes to setPredecessorNodes in DynamicNode.tsx and RouterNode.tsx.
    • Use nodeConfig instead of data.config in CoalesceNode.tsx for preferences and title.
    • Improve node width calculation logic in DynamicNode.tsx, CoalesceNode.tsx, and RouterNode.tsx.
    • Add isEqual check for node updates in RouterNode.tsx and CoalesceNode.tsx.
  • Store:
    • Add preferences to FlowWorkflowNodeConfig in flowSlice.ts.

This description was created by Ellipsis for 2c876e7. It will automatically update as commits are pushed.

@JeanKaddour JeanKaddour merged commit af73b18 into perf/flowSlicev2 Dec 31, 2024
Copy link
Copy Markdown
Contributor

@ellipsis-dev ellipsis-dev Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Changes requested. Reviewed everything up to 2c876e7 in 1 minute and 28 seconds

More details
  • Looked at 466 lines of code in 6 files
  • Skipped 0 files when reviewing.
  • Skipped posting 4 drafted comments based on config settings.
1. backend/app/api/key_management.py:82
  • Draft comment:
    Fix indentation for the raise HTTPException line to align with the if statement.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The indentation for the raise HTTPException line is incorrect, which affects readability and consistency.
2. backend/app/api/key_management.py:97
  • Draft comment:
    Fix indentation for the raise HTTPException line to align with the if statement.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The indentation for the raise HTTPException line is incorrect, which affects readability and consistency.
3. frontend/src/components/nodes/logic/CoalesceNode.tsx:52
  • Draft comment:
    Remove the console.log statement to avoid unnecessary logging in production.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The variable nodeConfig is being logged to the console, which might be unnecessary for production code. It could be a leftover from debugging.
4. frontend/src/components/nodes/logic/RouterNode.tsx:74
  • Draft comment:
    Remove the console.log statement to avoid unnecessary logging in production.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The variable nodeConfig is being logged to the console, which might be unnecessary for production code. It could be a leftover from debugging.

Workflow ID: wflow_a1qlKZhboNFD8OVA


Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

};

// Recompute predecessor nodes whenever edges/connections change
useEffect(() => {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This logic is duplicated. Consider extracting it into a shared custom hook like usePredecessorNodes(id, edges, nodes, connection).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants