Bugfix/conditional node#69
Merged
JeanKaddour merged 6 commits intoperf/flowSlicev2from Dec 31, 2024
Merged
Conversation
…t/conditional-node-sidebar
…onfig.preferences
…width calculation
Contributor
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to 2c876e7 in 1 minute and 28 seconds
More details
- Looked at
466lines of code in6files - Skipped
0files when reviewing. - Skipped posting
4drafted comments based on config settings.
1. backend/app/api/key_management.py:82
- Draft comment:
Fix indentation for theraise HTTPExceptionline to align with theifstatement. - Reason this comment was not posted:
Confidence changes required:50%
The indentation for the raise HTTPException line is incorrect, which affects readability and consistency.
2. backend/app/api/key_management.py:97
- Draft comment:
Fix indentation for theraise HTTPExceptionline to align with theifstatement. - Reason this comment was not posted:
Confidence changes required:50%
The indentation for the raise HTTPException line is incorrect, which affects readability and consistency.
3. frontend/src/components/nodes/logic/CoalesceNode.tsx:52
- Draft comment:
Remove the console.log statement to avoid unnecessary logging in production. - Reason this comment was not posted:
Confidence changes required:50%
The variablenodeConfigis being logged to the console, which might be unnecessary for production code. It could be a leftover from debugging.
4. frontend/src/components/nodes/logic/RouterNode.tsx:74
- Draft comment:
Remove the console.log statement to avoid unnecessary logging in production. - Reason this comment was not posted:
Confidence changes required:50%
The variablenodeConfigis being logged to the console, which might be unnecessary for production code. It could be a leftover from debugging.
Workflow ID: wflow_a1qlKZhboNFD8OVA
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
| }; | ||
|
|
||
| // Recompute predecessor nodes whenever edges/connections change | ||
| useEffect(() => { |
Contributor
There was a problem hiding this comment.
This logic is duplicated. Consider extracting it into a shared custom hook like usePredecessorNodes(id, edges, nodes, connection).
- predecessor node management logic (CoalesceNode.tsx)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Add Deepseek model support, fix typo, and improve node handling in frontend.
DEEPSEEK_API_KEYtoMODEL_PROVIDER_KEYSinkey_management.py.DEEPSEEKtoLLMProviderandDEEPSEEK_CHATtoLLMModelsinllm_utils.py.setPredcessorNodestosetPredecessorNodesinDynamicNode.tsxandRouterNode.tsx.nodeConfiginstead ofdata.configinCoalesceNode.tsxfor preferences and title.DynamicNode.tsx,CoalesceNode.tsx, andRouterNode.tsx.isEqualcheck for node updates inRouterNode.tsxandCoalesceNode.tsx.preferencestoFlowWorkflowNodeConfiginflowSlice.ts.This description was created by
for 2c876e7. It will automatically update as commits are pushed.