Chore/postgres#77
Merged
srijanpatel merged 18 commits intomainfrom Jan 6, 2025
Merged
Conversation
…ocker-compose.yml
…oving redundant checks and directly upgrading the database schema before starting the server.
Collaborator
Author
|
@ellipsis-dev review this |
Contributor
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 0edbfd9 in 20 seconds
More details
- Looked at
672lines of code in20files - Skipped
0files when reviewing. - Skipped posting
4drafted comments based on config settings.
1. backend/app/schemas/run_schemas.py:18
- Draft comment:
The change fromworkflow_version_id: inttoworkflow_version_id: straligns with the change in the database model whereworkflow_version_idis now a string. This ensures consistency between the database model and the API schema. - Reason this comment was not posted:
Confidence changes required:0%
The change fromworkflow_version_id: inttoworkflow_version_id: strin theRunResponseSchemaaligns with the change in the database model whereworkflow_version_idis now a string. This ensures consistency between the database model and the API schema.
2. frontend/src/types/api_types/runSchemas.ts:14
- Draft comment:
The change fromworkflow_version_id: numbertoworkflow_version_id: stringaligns with the change in the database model whereworkflow_version_idis now a string. This ensures consistency between the database model and the API schema. - Reason this comment was not posted:
Confidence changes required:0%
The change fromworkflow_version_id: inttoworkflow_version_id: strin theRunResponseinterface aligns with the change in the database model whereworkflow_version_idis now a string. This ensures consistency between the database model and the API schema.
3. backend/app/api/workflow_run.py:37
- Draft comment:
The change fromworkflow_version_id: inttoworkflow_version_id: straligns with the change in the database model whereworkflow_version_idis now a string. This ensures consistency between the database model and the API schema. - Reason this comment was not posted:
Confidence changes required:0%
The change fromworkflow_version_id: inttoworkflow_version_id: strin thecreate_run_modelfunction aligns with the change in the database model whereworkflow_version_idis now a string. This ensures consistency between the database model and the API schema.
4. backend/app/models/run_model.py:36
- Draft comment:
The change fromworkflow_version_id: inttoworkflow_version_id: straligns with the change in the database model whereworkflow_version_idis now a string. This ensures consistency between the database model and the API schema. - Reason this comment was not posted:
Confidence changes required:0%
The change fromworkflow_version_id: inttoworkflow_version_id: strin theRunModelclass aligns with the change in the database model whereworkflow_version_idis now a string. This ensures consistency between the database model and the API schema.
Workflow ID: wflow_gAJcwaie6MB47lax
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Contributor
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 087f536 in 11 seconds
More details
- Looked at
23lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. README.md:72
- Draft comment:
Ensure that the.envfile is correctly configured with the necessary PostgreSQL environment variables before starting the services. - Reason this comment was not posted:
Confidence changes required:50%
The README.md file has been updated to reflect the switch from SQLite to PostgreSQL. The changes are consistent with the PR description and the intent to use PostgreSQL as the default database. The instructions for setting up the database have been updated accordingly.
Workflow ID: wflow_SG7X6MycHazTw2nb
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Switch from SQLite to PostgreSQL, update models and configurations, and enhance Docker setup for PostgreSQL support.
.env.example,alembic.ini, anddatabase.py.DATABASE_URLconstruction indatabase.pyto use PostgreSQL environment variables.workflow_version_idfrominttostrinworkflow_run.py,run_schemas.py, andrunSchemas.ts.unique=Truetoidfields in models likedataset_model.py,eval_run_model.py, and others.autoincrement="auto"to_intidfields in models likeeval_run_model.py,output_file_model.py, and others.docker-compose.ymlanddocker-compose.prod.yml.entrypoint.shto runalembic upgrade headon startup.psycopg2-binarytorequirements.txtfor PostgreSQL support.alembic/.gitignorefile.generate_migrations.shscript for automating Alembic migrations.This description was created by
for 087f536. It will automatically update as commits are pushed.