Support for Phi4 from Ollama#83
Merged
JeanKaddour merged 1 commit intoPySpur-Dev:mainfrom Jan 9, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to ebd6eb8 in 12 seconds
More details
- Looked at
25lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. backend/app/nodes/llm/_utils.py:97
- Draft comment:
The addition of theOLLAMA_PHI4model is consistent with the existing pattern for adding models. Ensure that themax_tokensvalue of 4096 is correct for this model. - Reason this comment was not posted:
Confidence changes required:33%
The addition of the new model 'OLLAMA_PHI4' seems consistent with the existing pattern for adding models. However, the max_tokens value for this model is set to 4096, which is consistent with other Ollama models, so it seems correct.
Workflow ID: wflow_LJVgWgPcHcIrSrJL
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Contributor
|
Thank you @pafend ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Add support for
OLLAMA_PHI4model inLLMModelsenum andget_model_info()in_utils.py.OLLAMA_PHI4toLLMModelsenum in_utils.py.get_model_info()in_utils.pyto includeOLLAMA_PHI4with constraints:max_tokens=4096,max_temperature=2.0.This description was created by
for ebd6eb8. It will automatically update as commits are pushed.