Feat/data connectors#90
Merged
preet-bhadra merged 8 commits intomainfrom Jan 17, 2025
Merged
Conversation
Update the return type of the validateGoogleAccessToken function to be a Promise of GoogleAccessTokenValidationResponse interface. This ensures that the function returns the expected response format.
This commit adds a new file, `youtube_transcript.py`, which contains the implementation of the `YouTubeTranscriptNode` class. This class is responsible for fetching the transcript of a YouTube video based on the provided video URL. Additionally, the commit includes updates to the `requirements.txt` file to add the necessary dependencies: `phidata`, `youtube_transcript_api`.
- Update .env.example to include a comment explaining how to use the GITHUB_ACCESS_TOKEN environment variable for GitHub OAuth configuration. - Add a new file, backend/app/nodes/integrations/github_list_pull_requests.py, which contains the implementation of the GitHubListPullRequestsNode. - Update backend/app/nodes/node_types.py to include the GitHubListPullRequestsNode in the list of supported node types.
…t/data-connectors
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to 87a6f5a in 1 minute and 51 seconds
More details
- Looked at
187lines of code in6files - Skipped
0files when reviewing. - Skipped posting
2drafted comments based on config settings.
1. backend/app/nodes/integrations/youtube_transcript.py:12
- Draft comment:
Ensure that thetranscriptfield is correctly typed. If the transcript is structured or has multiple parts, consider using a list or another structured type instead of a string. - Reason this comment was not posted:
Confidence changes required:50%
The YouTubeTranscriptNodeOutput class is using a string type for transcript, which might be correct if the transcript is a single string. However, if the transcript is structured or has multiple parts, a different type might be more appropriate.
2. backend/app/nodes/integrations/youtube_transcript.py:31
- Draft comment:
Consider handling specific exceptions instead of a genericExceptionto provide more meaningful error messages and better debugging information. - Reason this comment was not posted:
Marked as duplicate.
Workflow ID: wflow_SJxbeOfmYQOBA897
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
srijanpatel
approved these changes
Jan 16, 2025
Contributor
There was a problem hiding this comment.
❌ Changes requested. Incremental review on 7c39c7b in 51 seconds
More details
- Looked at
44lines of code in2files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. backend/app/nodes/integrations/youtube_transcript.py:34
- Draft comment:
Returning an empty string on error can lead to confusion. Consider returningNoneor raising a custom exception to better handle errors. - Reason this comment was not posted:
Marked as duplicate.
Workflow ID: wflow_Vb6IAH8vtQFRn01v
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
| return GitHubListPullRequestsNodeOutput(pull_requests=pull_requests) | ||
| except Exception as e: | ||
| logging.error(f"Failed to get pull requests: {e}") | ||
| return GitHubListPullRequestsNodeOutput(pull_requests="") |
Contributor
There was a problem hiding this comment.
Returning an empty string on error can lead to confusion. Consider returning None or raising a custom exception to better handle errors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Add GitHub and YouTube data connectors, update configurations, and dependencies.
GitHubListPullRequestsNodeingithub_list_pull_requests.pyto fetch pull requests from a specified GitHub repository.YouTubeTranscriptNodeinyoutube_transcript.pyto fetch transcripts from a specified YouTube video.GITHUB_ACCESS_TOKENto.env.examplefor GitHub OAuth configuration.GitHubListPullRequestsNodeandYouTubeTranscriptNodeinnode_types.py.phidata==2.7.8,youtube_transcript_api==0.6.3, andPyGithub==2.5.0torequirements.txt.StoreGoogleAccessTokenResponseandGoogleAccessTokenValidationResponseinterfaces inapi.ts.This description was created by
for 7c39c7b. It will automatically update as commits are pushed.