Skip to content

Feat/data connectors#91

Merged
preet-bhadra merged 7 commits intomainfrom
feat/data-connectors
Jan 18, 2025
Merged

Feat/data connectors#91
preet-bhadra merged 7 commits intomainfrom
feat/data-connectors

Conversation

@preet-bhadra
Copy link
Copy Markdown
Collaborator

@preet-bhadra preet-bhadra commented Jan 17, 2025

Important

Add logos to integration nodes and update frontend to display them in CollapsibleNodePanel.tsx.

  • Backend:
    • Add logo attribute to GitHubListPullRequestsNode, GoogleSheetsReadNode, and YouTubeTranscriptNode classes.
  • Frontend:
    • Update CollapsibleNodePanel.tsx to display node logos if available, otherwise show acronym tag.

This description was created by Ellipsis for 83a6242. It will automatically update as commits are pushed.

Copy link
Copy Markdown
Contributor

@ellipsis-dev ellipsis-dev Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 83a6242 in 18 seconds

More details
  • Looked at 67 lines of code in 4 files
  • Skipped 3 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. frontend/src/components/nodes/CollapsibleNodePanel.tsx:131
  • Draft comment:
    Ensure that the alt attribute for images is descriptive for better accessibility.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The code is missing alt text for images, which is important for accessibility.

Workflow ID: wflow_4zNq4QROuFQnTnQr


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@preet-bhadra preet-bhadra merged commit c7809bf into main Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants