Feat/data connectors#91
Merged
preet-bhadra merged 7 commits intomainfrom Jan 18, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 83a6242 in 18 seconds
More details
- Looked at
67lines of code in4files - Skipped
3files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. frontend/src/components/nodes/CollapsibleNodePanel.tsx:131
- Draft comment:
Ensure that thealtattribute for images is descriptive for better accessibility. - Reason this comment was not posted:
Confidence changes required:50%
The code is missing alt text for images, which is important for accessibility.
Workflow ID: wflow_4zNq4QROuFQnTnQr
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
…t/data-connectors
…t/data-connectors
srijanpatel
approved these changes
Jan 18, 2025
…t/data-connectors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Add logos to integration nodes and update frontend to display them in
CollapsibleNodePanel.tsx.logoattribute toGitHubListPullRequestsNode,GoogleSheetsReadNode, andYouTubeTranscriptNodeclasses.CollapsibleNodePanel.tsxto display node logos if available, otherwise show acronym tag.This description was created by
for 83a6242. It will automatically update as commits are pushed.