Skip to content

Fix json schema types in SchemaEditor and VariableOutputBaseNodeConfig#94

Merged
preet-bhadra merged 1 commit intomainfrom
bugfix/output-json-schema
Jan 18, 2025
Merged

Fix json schema types in SchemaEditor and VariableOutputBaseNodeConfig#94
preet-bhadra merged 1 commit intomainfrom
bugfix/output-json-schema

Conversation

@preet-bhadra
Copy link
Copy Markdown
Collaborator

@preet-bhadra preet-bhadra commented Jan 18, 2025

Important

Fix JSON schema type from 'str' to 'string' in VariableOutputBaseNodeConfig and SchemaEditor.tsx.

  • Backend:
    • Change default output_schema type from str to string in VariableOutputBaseNodeConfig in base.py.
  • Frontend:
    • Update getType function in SchemaEditor.tsx to return string instead of str for object types.

This description was created by Ellipsis for d33c286. It will automatically update as commits are pushed.

Copy link
Copy Markdown
Contributor

@ellipsis-dev ellipsis-dev Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to d33c286 in 14 seconds

More details
  • Looked at 26 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. frontend/src/components/nodes/nodeSidebar/SchemaEditor.tsx:53
  • Draft comment:
    Ensure that the getType function returns a valid JSON schema type for all possible inputs. The change from 'str' to 'string' is correct, but verify other types as well.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The change from 'str' to 'string' in the getType function aligns with the JSON schema type standards. However, the function should ensure that it returns a valid JSON schema type for all possible inputs.

Workflow ID: wflow_fZqLnFqseiQIKJVi


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@preet-bhadra preet-bhadra merged commit d5ab3d9 into main Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant