Fix json schema types in SchemaEditor and VariableOutputBaseNodeConfig#94
Merged
preet-bhadra merged 1 commit intomainfrom Jan 18, 2025
Merged
Fix json schema types in SchemaEditor and VariableOutputBaseNodeConfig#94preet-bhadra merged 1 commit intomainfrom
preet-bhadra merged 1 commit intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to d33c286 in 14 seconds
More details
- Looked at
26lines of code in2files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. frontend/src/components/nodes/nodeSidebar/SchemaEditor.tsx:53
- Draft comment:
Ensure that thegetTypefunction returns a valid JSON schema type for all possible inputs. The change from 'str' to 'string' is correct, but verify other types as well. - Reason this comment was not posted:
Confidence changes required:50%
The change from 'str' to 'string' in the getType function aligns with the JSON schema type standards. However, the function should ensure that it returns a valid JSON schema type for all possible inputs.
Workflow ID: wflow_fZqLnFqseiQIKJVi
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Fix JSON schema type from 'str' to 'string' in
VariableOutputBaseNodeConfigandSchemaEditor.tsx.output_schematype fromstrtostringinVariableOutputBaseNodeConfiginbase.py.getTypefunction inSchemaEditor.tsxto returnstringinstead ofstrfor object types.This description was created by
for d33c286. It will automatically update as commits are pushed.