Skip to content

Bugfix/reset run issues#99

Merged
srijanpatel merged 4 commits intomainfrom
bugfix/reset-run-issues
Jan 18, 2025
Merged

Bugfix/reset run issues#99
srijanpatel merged 4 commits intomainfrom
bugfix/reset-run-issues

Conversation

@srijanpatel
Copy link
Copy Markdown
Collaborator

@srijanpatel srijanpatel commented Jan 18, 2025

This pull request includes several updates to the useWorkflowExecution hook and a small change to the flowSlice reducer. The main focus is on improving the handling of status intervals during workflow execution and ensuring proper cleanup of intervals.

Improvements to useWorkflowExecution hook:

Update to flowSlice reducer:


Important

Improves interval management in useWorkflowExecution and resets error field in resetRun action of flowSlice.

  • Behavior:
    • useWorkflowExecution hook now uses useRef to manage multiple status intervals, ensuring they are cleared properly.
    • Replaces currentStatusInterval with statusIntervals array to track and clear all intervals in useWorkflowExecution.ts.
    • resetRun action in flowSlice.ts now resets the error field in each node's data.
  • Components:
    • Adds NodeOutputDisplay to InputNode.tsx to display node output when data.run is present.

This description was created by Ellipsis for 2526a12. It will automatically update as commits are pushed.

@srijanpatel srijanpatel merged commit 6425ff1 into main Jan 18, 2025
Copy link
Copy Markdown
Contributor

@ellipsis-dev ellipsis-dev Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 2526a12 in 38 seconds

More details
  • Looked at 118 lines of code in 3 files
  • Skipped 0 files when reviewing.
  • Skipped posting 4 drafted comments based on config settings.
1. frontend/src/components/nodes/InputNode.tsx:32
  • Draft comment:
    The showOutput state is defined but never used. Consider removing it if it's not needed.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The showOutput state is defined but never used in the component. This is likely an oversight and should be removed if not needed.
2. frontend/src/components/nodes/InputNode.tsx:349
  • Draft comment:
    The addition of NodeOutputDisplay for displaying data.run is a good enhancement for visualizing node output.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    The addition of NodeOutputDisplay is correct and aligns with the PR description. No issues here.
3. frontend/src/hooks/useWorkflowExecution.ts:30
  • Draft comment:
    The use of useRef to manage intervals is a good practice for ensuring proper cleanup. The logic for clearing intervals is correctly implemented.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    The use of useRef to manage intervals is a good practice to ensure proper cleanup. The logic for clearing intervals is correctly implemented.
4. frontend/src/store/flowSlice.ts:662
  • Draft comment:
    The resetRun action now correctly resets the error field, which aligns with the PR description and intent.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    The resetRun action now correctly resets the error field, which aligns with the PR description and intent.

Workflow ID: wflow_WWDB9RTJyAbfWGaG


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@srijanpatel srijanpatel deleted the bugfix/reset-run-issues branch February 7, 2025 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant