Bugfix/reset run issues#99
Merged
srijanpatel merged 4 commits intomainfrom Jan 18, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 2526a12 in 38 seconds
More details
- Looked at
118lines of code in3files - Skipped
0files when reviewing. - Skipped posting
4drafted comments based on config settings.
1. frontend/src/components/nodes/InputNode.tsx:32
- Draft comment:
TheshowOutputstate is defined but never used. Consider removing it if it's not needed. - Reason this comment was not posted:
Confidence changes required:50%
TheshowOutputstate is defined but never used in the component. This is likely an oversight and should be removed if not needed.
2. frontend/src/components/nodes/InputNode.tsx:349
- Draft comment:
The addition ofNodeOutputDisplayfor displayingdata.runis a good enhancement for visualizing node output. - Reason this comment was not posted:
Confidence changes required:0%
The addition ofNodeOutputDisplayis correct and aligns with the PR description. No issues here.
3. frontend/src/hooks/useWorkflowExecution.ts:30
- Draft comment:
The use ofuseRefto manage intervals is a good practice for ensuring proper cleanup. The logic for clearing intervals is correctly implemented. - Reason this comment was not posted:
Confidence changes required:0%
The use ofuseRefto manage intervals is a good practice to ensure proper cleanup. The logic for clearing intervals is correctly implemented.
4. frontend/src/store/flowSlice.ts:662
- Draft comment:
TheresetRunaction now correctly resets theerrorfield, which aligns with the PR description and intent. - Reason this comment was not posted:
Confidence changes required:0%
TheresetRunaction now correctly resets theerrorfield, which aligns with the PR description and intent.
Workflow ID: wflow_WWDB9RTJyAbfWGaG
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes several updates to the
useWorkflowExecutionhook and a small change to theflowSlicereducer. The main focus is on improving the handling of status intervals during workflow execution and ensuring proper cleanup of intervals.Improvements to
useWorkflowExecutionhook:frontend/src/hooks/useWorkflowExecution.ts: AddeduseRefto manage multiple status intervals and ensure they are cleared appropriately.frontend/src/hooks/useWorkflowExecution.ts: Replaced the singlecurrentStatusIntervalwith an arraystatusIntervalsto track all intervals and clear them when necessary. [1] [2] [3]Update to
flowSlicereducer:frontend/src/store/flowSlice.ts: Modified theresetRunaction to also reset theerrorfield in each node's data.Important
Improves interval management in
useWorkflowExecutionand resetserrorfield inresetRunaction offlowSlice.useWorkflowExecutionhook now usesuseRefto manage multiple status intervals, ensuring they are cleared properly.currentStatusIntervalwithstatusIntervalsarray to track and clear all intervals inuseWorkflowExecution.ts.resetRunaction inflowSlice.tsnow resets theerrorfield in each node's data.NodeOutputDisplaytoInputNode.tsxto display node output whendata.runis present.This description was created by
for 2526a12. It will automatically update as commits are pushed.