Skip to content

Fix a few more Zizmor-flagged workflow concerns#1092

Merged
N-Wouda merged 5 commits into
mainfrom
restrict-default-workflow-permissions
Apr 3, 2026
Merged

Fix a few more Zizmor-flagged workflow concerns#1092
N-Wouda merged 5 commits into
mainfrom
restrict-default-workflow-permissions

Conversation

@N-Wouda
Copy link
Copy Markdown
Member

@N-Wouda N-Wouda commented Apr 3, 2026

This PR:

  • Closes #xxxx.
  • Adds and passes relevant tests.
  • Has well-formatted code and documentation.

To check:

  • CI
  • CD
  • CodSpeed
  • DOC
Details

Notes:

Please read our contributing guidelines first.
In particular:

  • You must add tests when making code changes.
    This keeps the code coverage level up, and helps ensure the changes work as intended.
  • When fixing a bug, you must add a test that would produce the bug in the master branch, and then show that it is fixed with the new code.
  • New code additions must be well formatted. Changes should pass the pre-commit workflow, which you can set up locally using pre-commit.
  • Docstring additions must render correctly, including escapes and LaTeX.
  • Finally, it is essential that all contributions in this PR are license-compatible with PyVRP's MIT license.
    Please check that this PR can be included into PyVRP under the MIT license.

@N-Wouda N-Wouda marked this pull request as ready for review April 3, 2026 10:06
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.17%. Comparing base (6d709e1) to head (548f329).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1092   +/-   ##
=======================================
  Coverage   95.17%   95.17%           
=======================================
  Files          77       77           
  Lines        4146     4146           
  Branches     1346     1346           
=======================================
  Hits         3946     3946           
  Misses         18       18           
  Partials      182      182           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Apr 3, 2026

Merging this PR will not alter performance

✅ 57 untouched benchmarks


Comparing restrict-default-workflow-permissions (548f329) with main (6d709e1)

Open in CodSpeed

@N-Wouda N-Wouda requested a review from leonlan April 3, 2026 10:46
@N-Wouda N-Wouda merged commit 059c87a into main Apr 3, 2026
9 checks passed
@N-Wouda N-Wouda deleted the restrict-default-workflow-permissions branch April 3, 2026 13:36
FormelessPuppy41 added a commit to FormelessPuppy41/PyVRP that referenced this pull request May 21, 2026
* Fix evaluation of moves that leave a route empty (without clients) (PyVRP#1090)

* Add failing test

* Fix evaluation of moves that leave a route empty (without clients)

* Remove Proposal::size()

* Implement numClients() for segments

* Bump configure-pages and deploy-pages actions (PyVRP#1091)

* Bump configure-pages and deploy-pages actions to versions that use Node 24

* Also bump codecov

(codecov@v5 depends on github-script@v7, which runs with Node 20. github-script@v8 runs with Node 24, and codecov@v6 has that dependency)

* Fix a few more Zizmor-flagged workflow concerns (PyVRP#1092)

* Exclude releases from <7 days ago from dependency resolution (PyVRP#1093)

* Clear when update leaves route empty (PyVRP#1094)

* Split off data components to separate files (PyVRP#1096)

* Split off data components to separate header and source files

* Split tests

* Phrasing PyVRP Enterprise

* Track unplanned clients (PyVRP#1103)

* Bump upload-pages-artifact to v5 (PyVRP#1104)

* Add an AI policy, and a FAQ entry about modifying the C+ components (PyVRP#1106)

* Add Rybbit analytics to docs pages

* Merge remote-tracking branch 'upstream/main' into merge-upstream-2026-05-21

* Make CI/CD fork-safe for missing Codecov/Pages/PyPI setup

* Fix CodSpeed workflow secret checks in if conditions

* Fix CI workflow token checks in if conditions

---------

Co-authored-by: Niels Wouda <N-Wouda@users.noreply.github.com>
Co-authored-by: Niels Wouda <nielswouda@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants