fix bug in FswavedecnResult.__setitem__ and improve docstrings#423
Conversation
add a simple example to the fswavedecn docstring
|
It looks like numpy 1.9 did not support using apparently use as a context manager requires numpy >= 1.11 |
this change is necessary for the tests to pass on numpy <1.11
|
closes #424 |
|
quick question: the dict -> list change is doc-only (was a doc error), and then |
|
I don't think there is a backcompat issue. The |
|
Okay thanks @grlee77 . LGTM, merged. |
From a few days from now till the end of October I have almost no bandwidth. Feel free to just push some commits through if you want to get a bug fix release out. |
|
Thanks. I will probably create 1.0.x branch starting from the tag for 1.0.0 and then cherry pick the commits from this PR and #427. I will then plan to make a 1.0.1 release in the next week or so. |
There was a bug in the dtype check in the setitem method of FswavedecnResult that prevents assigning modified coefficients. I think this probably warrants a 1.0.1 release to address.
The issue is that the user is supposed to be able to do something like:
A workaround in 1.0.0 is to do:
This PR also improves testing of the FswaverecnResult and makes a few docstring improvements.