Skip to content

fix: allow ForumTag to be created without an emoji#3245

Open
zeusec wants to merge 2 commits into
Pycord-Development:masterfrom
zeusec:fix/forumtag-optional-emoji
Open

fix: allow ForumTag to be created without an emoji#3245
zeusec wants to merge 2 commits into
Pycord-Development:masterfrom
zeusec:fix/forumtag-optional-emoji

Conversation

@zeusec
Copy link
Copy Markdown

@zeusec zeusec commented May 28, 2026

Summary

Made emoji optional by defaulting it to None, so you can create a ForumTag without one.
Fixes #3244

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.
  • AI Usage has been disclosed.
    • If AI has been used, I understand fully what the code does

@zeusec zeusec requested review from a team May 28, 2026 21:17
@zeusec zeusec requested a review from JustaSqu1d May 28, 2026 21:17
@github-project-automation github-project-automation Bot moved this to Todo in Pycord May 28, 2026
@zeusec zeusec requested a review from plun1331 May 28, 2026 21:17
@zeusec zeusec requested review from a team as code owners May 28, 2026 21:17
@zeusec zeusec requested review from Paillat-dev and removed request for a team May 28, 2026 21:17
@pycord-app
Copy link
Copy Markdown

pycord-app Bot commented May 28, 2026

Thanks for opening this pull request!
Please make sure you have read the Contributing Guidelines and Code of Conduct.

This pull request can be checked-out with:

git fetch origin pull/3245/head:pr-3245
git checkout pr-3245

This pull request can be installed with:

pip install git+https://github.com/Pycord-Development/pycord@refs/pull/3245/head

Comment thread discord/channel.py Outdated
Comment thread discord/channel.py Outdated
@Paillat-dev Paillat-dev added the hold: testing This pull request requires further testing label May 29, 2026
@Paillat-dev Paillat-dev modified the milestones: 2.10.0rc1, 2.9.0rc1, 2.8.1 May 29, 2026
Comment thread discord/channel.py
Comment thread discord/channel.py Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hold: testing This pull request requires further testing

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

ForumTag cannot be created without setting an emoji

3 participants