fix(workspace-mode): accept legacy "direct" alias for Local#8
Merged
Merged
Conversation
Old clients and any persisted state from before the Direct→Local rename still send `workspaceMode: "direct"`, which breaks `POST /api/threads` deserialization with `unknown variant 'direct'`. Add a serde alias so the gateway keeps accepting the old value while clients catch up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WorkspaceMode::Direct→Local(serde value"direct"→"local"), any client or persisted state still emitting"direct"makesPOST /api/threadsfail withunknown variant 'direct'.Error invoking remote method 'garyx:create-thread': Failed to deserialize JSON body — workspaceMode: unknown variant 'direct'when creating a new thread.#[serde(alias = "direct")]onWorkspaceMode::Localso legacy payloads keep deserializing while the rename rolls out everywhere.Test plan
cargo test -p garyx-router workspace_mode— extendedworkspace_mode_serializes_public_local_nameto assert"direct"still parses asLocal.cargo test -p garyx-router -p garyx-gateway— full suites pass (193 router tests, 0 failures).