Skip to content

fix: image processing and adjust client initializing#15

Merged
Pymetheus merged 3 commits into
mainfrom
develop
May 1, 2026
Merged

fix: image processing and adjust client initializing#15
Pymetheus merged 3 commits into
mainfrom
develop

Conversation

@Pymetheus
Copy link
Copy Markdown
Owner

Description

Convert images in RGBA/P mode to RGB before resizing to avoid format errors during processing. Initialize Twitter/Bluesky API clients only when their features are enabled. Add handling for ImageProcessingError in the bot's publish flow and slightly adjust MIN_SLEEP_TIME/MAX_SLEEP_TIME values. Also add stsci.edu to dev space_handles in the dev config.

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Code refactoring
  • Performance improvement
  • Test addition or update

Related Issue

Avoiding format errors during processing

Changes Made

  • Convert images in RGBA/P mode to RGB before resizing to avoid format errors during processing.
  • Initialize Twitter/Bluesky API clients only when their features are enabled.
  • Adjust MIN_SLEEP_TIME/MAX_SLEEP_TIME values.

Testing

Describe how you tested your changes:

  • Unit tests pass
  • Integration tests pass
  • Manual testing performed

Screenshots (if applicable)

Add screenshots to help explain your changes.

Checklist

  • My code follows the project's style guidelines
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Pymetheus and others added 3 commits April 14, 2026 23:12
ci: restructure project, update dependencies, and enhance CI configuration
Convert images in RGBA/P mode to RGB before resizing to avoid format errors during processing. Initialize Twitter/Bluesky API clients only when their features are enabled. Add handling for ImageProcessingError in the bot's publish flow and slightly adjust MIN_SLEEP_TIME/MAX_SLEEP_TIME values. Also add stsci.edu to dev space_handles in the dev config.
Add an inline type comment ('# type: Image.Image') to the value returned by Image.open in ImageProcessor (src/pimetheus/infrastructure/image/processor.py) to improve static typing and IDE support. No runtime behavior changes.
@github-actions github-actions Bot added the bug Types: Something is broken or not working label May 1, 2026
@Pymetheus Pymetheus merged commit 8d91837 into main May 1, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Types: Something is broken or not working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant