-
Notifications
You must be signed in to change notification settings - Fork 562
Check Var bounds when setting values #2196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2196 +/- ##
==========================================
- Coverage 82.99% 82.96% -0.03%
==========================================
Files 607 607
Lines 76774 76756 -18
==========================================
- Hits 63718 63684 -34
- Misses 13056 13072 +16
Continue to review full report at Codecov.
|
michaelbynum
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great.
Fixes # .
Summary/Motivation:
This implements the first 2 proposals from #2180:
Changes proposed in this PR:
set_value()andfix()implementations consistent acrossVar,BooleanVar,AutoLinkedBinaryVarandAutoLinkedBooleanVarcontrib.constraints_to_var_boundsthat could move a var value outside its boundsLegal Acknowledgement
By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution: