Skip to content

Conversation

@jsiirola
Copy link
Member

@jsiirola jsiirola commented Dec 1, 2021

Fixes #2213

Summary/Motivation:

This resolves reversed op codes for floor() and ceil() in the AMPL writer. The updated test baseline (small14.pyomo.nl) was verified to be correct (by diffing against small14.ampl.nl, freshly regenerated using AMPL).

Changes proposed in this PR:

  • reverse the op codes for floor/ceil in the NL writer
  • update a test baseline (the baseline appears to have been testing an erroneous behavior)

Legal Acknowledgement

By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the BSD license.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@codecov
Copy link

codecov bot commented Dec 1, 2021

Codecov Report

Merging #2216 (dc86edf) into main (c2e92b9) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2216   +/-   ##
=======================================
  Coverage   82.97%   82.97%           
=======================================
  Files         607      607           
  Lines       76782    76782           
=======================================
  Hits        63709    63709           
  Misses      13073    13073           
Impacted Files Coverage Δ
pyomo/repn/plugins/ampl/ampl_.py 87.67% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2e92b9...dc86edf. Read the comment docs.

@michaelbynum michaelbynum merged commit 45896d9 into Pyomo:main Dec 1, 2021
@jsiirola jsiirola deleted the nl-floor-ceil branch December 8, 2021 18:35
jsiirola added a commit to jsiirola/pyomo that referenced this pull request Dec 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Floor and ceil operator codes switched in NL file writer

2 participants