Add remove_nodes method to IncidenceGraphInterface
#2240
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2240 +/- ##
=======================================
Coverage 83.05% 83.05%
=======================================
Files 607 607
Lines 76968 77000 +32
=======================================
+ Hits 63923 63955 +32
Misses 13045 13045
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
blnicho
approved these changes
Jan 5, 2022
jsiirola
reviewed
Jan 11, 2022
Member
jsiirola
left a comment
jsiirola
left a comment
There was a problem hiding this comment.
I think this is OK, but there is a small change that you can make to make the API a little more flexible,
…nto incidence-remove
jsiirola
changed the title
remove method to IncidenceGraphInterfaceremove_nodes method to IncidenceGraphInterface
jsiirola
approved these changes
Jan 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary/Motivation:
When debugging a model that has an unexpected overconstrained or underconstrained subsystem, a common task we want to do is remove a particular variable and constraint from the incidence graph/matrix, the equivalent of fixing a variable and deactivating a constraint. This can help narrow down the "cause" of the unexpected overconstrained/underconstrained system. This is currently possible by fixing/deactivating, then re-constructing the incidence graph, but would be nice to do this without altering the Pyomo model. This motivates the addition of a method on
IncidenceGraphInterfacefor removing nodes from an incidence graph. Note this is "projecting" variables and constraints out of the model, rather than doing some sort of vertex elimination (where new edges/nonzeros would be added to the graph).Changes proposed in this PR:
removemethod toIncidenceGraphInterfacethat removes columns and rows corresponding to provided variables and constraints from the cached incidence matrixLegal Acknowledgement
By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution: