Skip to content

Conversation

@michaelbynum
Copy link
Contributor

Summary/Motivation:

A few of the FBBT tests are failing due to floating point comparisons. They are off in the 16th digit. This PR adds a small tolerance to make the tests more robust.

Legal Acknowledgement

By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the BSD license.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@codecov
Copy link

codecov bot commented Jan 5, 2022

Codecov Report

Merging #2244 (1e90d7c) into main (593735b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2244   +/-   ##
=======================================
  Coverage   83.05%   83.05%           
=======================================
  Files         607      607           
  Lines       76968    76968           
=======================================
  Hits        63923    63923           
  Misses      13045    13045           
Flag Coverage Δ
linux 80.33% <ø> (-0.01%) ⬇️
osx 70.59% <ø> (-0.03%) ⬇️
other 80.27% <ø> (-0.03%) ⬇️
win 77.40% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 593735b...1e90d7c. Read the comment docs.

@jsiirola jsiirola changed the title Failing tests Resolve failing FBBT tests Jan 5, 2022
@jsiirola jsiirola merged commit 0034fd0 into Pyomo:main Jan 5, 2022
@michaelbynum michaelbynum deleted the failing_tests branch February 22, 2022 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants