Skip to content

Conversation

@michaelbynum
Copy link
Contributor

Changes proposed in this PR:

  • Improve testing for PyNumero's MPIBlockMatrix

Legal Acknowledgement

By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the BSD license.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@codecov
Copy link

codecov bot commented Feb 25, 2022

Codecov Report

Merging #2318 (588c721) into main (536deaa) will increase coverage by 0.16%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2318      +/-   ##
==========================================
+ Coverage   85.24%   85.40%   +0.16%     
==========================================
  Files         619      619              
  Lines       76453    76572     +119     
==========================================
+ Hits        65169    65393     +224     
+ Misses      11284    11179     -105     
Flag Coverage Δ
linux 82.42% <100.00%> (+0.35%) ⬆️
osx 72.66% <0.00%> (+0.20%) ⬆️
other 82.37% <100.00%> (+0.36%) ⬆️
win 79.46% <0.00%> (+0.22%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pyomo/contrib/pynumero/sparse/block_matrix.py 89.96% <ø> (+0.29%) ⬆️
pyomo/contrib/pynumero/sparse/mpi_block_matrix.py 81.23% <100.00%> (+14.46%) ⬆️
pyomo/core/kernel/dict_container.py 98.86% <0.00%> (-1.14%) ⬇️
pyomo/solvers/plugins/solvers/gurobi_direct.py 71.91% <0.00%> (-0.51%) ⬇️
examples/pyomobook/test_book_examples.py 96.80% <0.00%> (-0.41%) ⬇️
pyomo/contrib/appsi/solvers/gurobi.py 82.90% <0.00%> (-0.35%) ⬇️
pyomo/core/kernel/block.py 99.70% <0.00%> (-0.30%) ⬇️
pyomo/contrib/mindtpy/iterate.py 83.56% <0.00%> (+1.82%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 536deaa...588c721. Read the comment docs.

Copy link
Member

@jsiirola jsiirola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@jsiirola jsiirola changed the title working on pynumero mpi block matrix tests Improve coverage of pynumero mpi block matrix tests Feb 26, 2022
@jsiirola jsiirola merged commit 08f49dc into Pyomo:main Feb 26, 2022
@michaelbynum michaelbynum deleted the pynumero branch May 11, 2022 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants