Skip to content

Conversation

@mrmundt
Copy link
Contributor

@mrmundt mrmundt commented Mar 3, 2022

Fixes NA

Summary/Motivation:

The APPSI distributables are inconsistent in behavior on Windows. They would consistently with conda on 3.7 and 3.8, but not on 3.9+; with pip, it seems to depend on machine. As a result, rather than try to chase down the issue, we are going to remove APPSI distributables from the release.

Changes proposed in this PR:

  • Remove APPSI distributables for Windows

Legal Acknowledgement

By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the BSD license.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@mrmundt mrmundt requested a review from jsiirola March 3, 2022 20:50
@codecov
Copy link

codecov bot commented Mar 3, 2022

Codecov Report

Merging #2326 (7ae47a6) into main (b48c886) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2326      +/-   ##
==========================================
- Coverage   85.61%   85.60%   -0.01%     
==========================================
  Files         618      618              
  Lines       76206    76206              
==========================================
- Hits        65241    65238       -3     
- Misses      10965    10968       +3     
Flag Coverage Δ
linux 82.42% <ø> (ø)
osx 72.67% <ø> (ø)
other 82.37% <ø> (ø)
win 79.47% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pyomo/common/env.py 89.15% <0.00%> (-2.01%) ⬇️
pyomo/solvers/plugins/solvers/ASL.py 91.42% <0.00%> (+1.42%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b48c886...7ae47a6. Read the comment docs.

@jsiirola
Copy link
Member

jsiirola commented Mar 8, 2022

(upon further testing, it looks like this change does not actually fix the appsi cmodel import error on Windows.)

@mrmundt mrmundt changed the title Move to windows-2019 for wheel building Remove APPSI Distributables from Windows Mar 8, 2022
@mrmundt mrmundt requested review from jsiirola and michaelbynum March 8, 2022 18:19
@blnicho blnicho merged commit 716c733 into Pyomo:main Mar 8, 2022
@mrmundt mrmundt deleted the build-dist branch March 29, 2022 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants