Auto-Linting: Spelling Black Style Checker #2800
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2800 +/- ##
=======================================
Coverage 87.00% 87.01%
=======================================
Files 763 763
Lines 87213 87213
=======================================
+ Hits 75881 75886 +5
+ Misses 11332 11327 -5
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 73 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Robbybp
left a comment
Robbybp
left a comment
There was a problem hiding this comment.
I went through the contrib files and noted a few places where user code could break. I'm still in favor of merging, just making sure people are aware.
| addtoSet.addone(ParmestScen("ExpScen" + str(exp_num), ThetaVals, prob)) | ||
|
|
||
| def ScenariosFromBoostrap(self, addtoSet, numtomake, seed=None): | ||
| def ScenariosFromBootstrap(self, addtoSet, numtomake, seed=None): |
There was a problem hiding this comment.
This could break a user's code, right? Should a deprecation path be added?
|
|
||
| for index, ThetaVals in dfdict.items(): | ||
| name = "Boostrap" + str(index) | ||
| name = "Bootstrap" + str(index) |
There was a problem hiding this comment.
Is this name used anywhere?
| version='5.7', | ||
| ) | ||
| class TightenContraintFromVars(IsomorphicTransformation): | ||
| class TightenConstraintFromVars(IsomorphicTransformation): |
There was a problem hiding this comment.
This could potentially break a user's code, although TransformationFactory would be the usual way to construct this object, which doesn't change, and the transformation is already deprecated.
3 participants
Fixes #329
Summary/Motivation:
Finally, this is the PR that adds in the auto-linting pre-req for the regular testing suite.
Changes proposed in this PR:
.github/workflows/typos.tomlexamples/pyomobook/python-ch/BadIndent.pyfile as it is intentionally wrong).git-blame-ignore-revsfile which can be used to ignore all of the black style changes when running agit blamecommand:git blame --ignore-revs-file .git-blame-ignore-revsgit config blame.ignoreRevsFile .git-blame-ignore-revsLegal Acknowledgement
By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution: