-
Notifications
You must be signed in to change notification settings - Fork 562
LPv2 writer #2823
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
LPv2 writer #2823
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrmundt
approved these changes
May 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Summary/Motivation:
This PR introduces three significant things:
pyomo.repn.pluvins.lp_writer): complete overhaul of the LP writer that is 30-40% fasterONE_VAR_CONSTANTwhen it is required and will never emit thec_e_ONE_VAR_CONSTANTconstraint (this lead to a lot of LP file baseline updates)pyomo.repn.linear): new expression compiler, roughly equivalent togenerate_standard_repn(compute_values=True, quadratic=False)pyomo.repn.quadratic): new expression compiler, roughly equivalent togenerate_standard_repn(compute_values=True, quadratic=True)It also adds a
lp_difflibrary for more robust comparisons of LP files (similar in structure to thenl_difflibrary). Both differs have been moved up topyomo.repn.tests.This PR activated the new writer as the default (and just updates all the baselines) in order to get full test coverage. If desired, we can go back and preserve multiple baselines to allow for a transition period.
Additional testing for the walkers will be forthcoming, but I wanted to get the PR up so people could start looking at it.
Performance:
Changes proposed in this PR:
Legal Acknowledgement
By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution: