Skip to content

[KNITRO] Add warm start support#3833

Merged
blnicho merged 23 commits into
Pyomo:mainfrom
eminyouskn:knitro-warm-start
May 16, 2026
Merged

[KNITRO] Add warm start support#3833
blnicho merged 23 commits into
Pyomo:mainfrom
eminyouskn:knitro-warm-start

Conversation

@eminyouskn
Copy link
Copy Markdown
Contributor

Fixes # .

Summary/Motivation:

This PR implements the warm-start procedure for the KNITRO solver.

Changes proposed in this PR:

Legal Acknowledgement

By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the BSD license.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@blnicho blnicho requested a review from michaelbynum February 24, 2026 20:01
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 29, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.12%. Comparing base (787c6ff) to head (3115e08).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3833   +/-   ##
=======================================
  Coverage   90.12%   90.12%           
=======================================
  Files         905      905           
  Lines      107490   107505   +15     
=======================================
+ Hits        96873    96890   +17     
+ Misses      10617    10615    -2     
Flag Coverage Δ
builders 29.13% <20.00%> (+<0.01%) ⬆️
default 86.46% <100.00%> (?)
expensive 35.21% <20.00%> (?)
linux 87.60% <20.00%> (-2.02%) ⬇️
linux_other 87.60% <20.00%> (-0.01%) ⬇️
oldsolvers 28.08% <20.00%> (+<0.01%) ⬆️
osx 82.98% <20.00%> (-0.01%) ⬇️
win 85.51% <20.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

@michaelbynum michaelbynum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR looks great, but it raised a broader design discussion for solver configs (see #3933 ). We are trying to figure out how to have common config options among subsets of solvers. For this PR, I think we just rename use_start to be knitro_use_warmstart so that it is clear that this option is specific to knitro. With that change, I think this will be ready to go.

@mrmundt mrmundt dismissed michaelbynum’s stale review May 15, 2026 19:37

Change was made

Copy link
Copy Markdown
Member

@blnicho blnicho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found one small typo. Assuming there are no other edits to make on this, we can fix the typo right before merging without waiting for tests to run again.

Comment thread pyomo/contrib/solver/solvers/knitro/config.py Outdated
Co-authored-by: Bethany Nicholson <blnicho@users.noreply.github.com>
@blnicho blnicho merged commit 59e225e into Pyomo:main May 16, 2026
33 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants