Add CartesianProductSet to PyROS#3927
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3927 +/- ##
==========================================
+ Coverage 90.07% 90.08% +0.01%
==========================================
Files 904 904
Lines 107003 107081 +78
==========================================
+ Hits 96384 96469 +85
+ Misses 10619 10612 -7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jsiirola
left a comment
There was a problem hiding this comment.
This looks good. Some minor updates to docstrings if you have time, but (in my opinion) nothing that must prevent merging.
|
@shermanjasonaf - The Jenkins tests are not related to you. Theoretically they should be fixed on the next re-run. |
|
@jas-yao @jsiirola, which of the following do you prefer?
We should also ensure that the PyROS version number and changelog are updated after each PR according to the merging order that we decide upon. |
|
@shermanjasonaf - I'm happy to merge this. Please let me know what you'd like. |
Summary/Motivation:
This PR adds to PyROS the
CartesianProductSetclass, a new pre-implemented concreteUncertaintySetsubclass for representing a Cartesian product (or cross product) of uncertainty sets. For simplicity, this initial implementation of theCartesianProductSetdoes not support products involving one or more discrete uncertainty sets; such support will be added in a future PR.Changes proposed in this PR:
CartesianProductSetclassLegal Acknowledgement
By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution: