This repository was archived by the owner on Jul 3, 2025. It is now read-only.
Ores to Field Guide#5
Merged
Pyritie merged 8 commits intoFeb 2, 2025
Merged
Conversation
Pyritie
reviewed
Feb 2, 2025
Pyritie
approved these changes
Feb 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the new behavior?
This PR adds the finalized version of the Ores to Field Guide program, allowing for automatic creating of patchouli entries via the utilization of localization tokens and mineral data json files.
Implementation Details
The program itself was written using newtonsoft JSON's capabilities for deserializing and serializing objects from .NET to JSON
The following key classes exist:
Main Class
The actual class with the program's entrypoint, above it has some precompiler clauses that can be commented and uncommented to allow the change of some outcomes.
.minecraft/kubejs/assets/../tfg_ores/Program Arguments:
The actual arguments used by the program, these are obtained "automagically" based off assumptions.
JSONObjects
A folder instead of a class, this folder contains any and all JSON related objects such as:
Outcome
Updating the field guide's ore entries is no longer torture
Additional Information
This is a bit of a mess, i tried to explain the thought process where applicable, but if you need some explanation lmk
Potential Compatibility Issues
Only if youre not based