Skip to content

Conversation

@iflare3g
Copy link

@iflare3g iflare3g commented Oct 2, 2020

  • Split django settings into base, dev, test and prod
  • The default one is the dev settings so in Production must be specified the settings module by DJANGO_SETTINGS_MODULE env variable or for example you can change the settings when running the runserver via --settings option

- Split django settings into base, dev, test and prod
@iflare3g iflare3g force-pushed the feature/split-settings branch from 91d47ee to 0967319 Compare October 2, 2020 10:36
@iflare3g iflare3g mentioned this pull request Oct 2, 2020
@psalmskalu
Copy link
Contributor

Your change is conflicting. Some changes have been made to the settings.py file. Kindly pull the project again and split the settings with the new values to be merged

@psalmskalu psalmskalu closed this Oct 5, 2020
@iflare3g
Copy link
Author

iflare3g commented Oct 5, 2020

But why closing the PR before giving me the time to update it according to your feedbacks ?

@psalmskalu
Copy link
Contributor

Sorry about that. Kindly clone again and make necessary changes. We were cleaning up to remove spam PRs

@iflare3g
Copy link
Author

iflare3g commented Oct 7, 2020

Ok nice, thanks for response!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants