-
-
Notifications
You must be signed in to change notification settings - Fork 80
Use cbor2pure by default #475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #475 +/- ##
==========================================
- Coverage 90.64% 90.57% -0.08%
==========================================
Files 33 34 +1
Lines 5153 5157 +4
Branches 781 782 +1
==========================================
Hits 4671 4671
- Misses 304 306 +2
- Partials 178 180 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Thanks for finally tackling this! Overall the approach is sound, just 2 minor notes. |
|
Thanks for reviewing and the suggestions! All tests are passing, merging now. |
|
@cffls This is huge! Thanks. It will make things much easier. |
This commit will ensure pure python version of cbor2 is used when installing pycardano for the first time, without modifying any dependencies. Users are still free to use cbor2 if speed is preferred over correctness by setting
CBOR_C_EXETENSION=1in their environment.A dynamic cbor2 module is also exported by pycardano, which allows users to use if they want to write custom version of decoder without worrying about using the wrong cbor library with pycardano.