fix: prevent mixed =/- chars in Setext-style headings (+tests)#1606
Open
Jah-yee wants to merge 2 commits into
Open
fix: prevent mixed =/- chars in Setext-style headings (+tests)#1606Jah-yee wants to merge 2 commits into
Jah-yee wants to merge 2 commits into
Conversation
The regex [=-]+ incorrectly matches mixed runs like '=-' or '-=' which are not valid Setext headers (only = or - alone are valid). Fix using (?:[=]+|[-]+) to match only homogeneous runs. Fixes issue Python-Markdown#1604
Reviewer requested tests for the fix preventing mixed =/- chars in Setext-style headings (issue Python-Markdown#1604, PR Python-Markdown#1605). Add 3 tests: - test_setext_mixed_chars_not_h1: =- should not form H1 - test_setext_mixed_chars_not_h2: -= should not form H2 - test_setext_mixed_multiple_chars: mixed runs not valid headers
Author
|
Added 3 test cases in tests/test_syntax/blocks/test_headers.py covering mixed-char rejection (test_setext_mixed_chars_not_h1, test_setext_mixed_chars_not_h2, test_setext_mixed_multiple_chars). All tests pass. The fix is ready for review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes issue #1604 - mixed =/- characters in Setext-style headers were incorrectly matched.
Changes
[=-]+to(?:[=]+|[-]+)to match only homogeneous runsTests Added
test_setext_mixed_chars_not_h1:=-should not form an H1test_setext_mixed_chars_not_h2:-=should not form an H2test_setext_mixed_multiple_chars: Mixed runs are not valid headersCloses #1604