Simplify xml.etree.ElementTree loading#902
Conversation
waylan
left a comment
There was a problem hiding this comment.
Simplifying the code by removing old cruft like this is great. However, the cruft has only been half removed. See my comments below for what need sot happen before this can be accepted.
cElementTree is a deprecated alias for ElementTree since Python 3.3. Also drop the recommendation to import etree from markdown.util, and deprecate markdown.util.etree.
7c4f523 to
0f48d17
Compare
waylan
left a comment
There was a problem hiding this comment.
This looks good. However, one thing is bothering me. Sometimes we import as etree and other times we don't do the as etree bit. Lets be consistent throughout the lib.
8b1f49a to
03c21fb
Compare
|
Ok. I decided to go with the |
|
We should probably add a note to the release notes informing extension devs that |
|
Done in 01ca739. Please check if the wording is fine. |
It was pretty good. I made a few adjustments to the first sentence for consistency (" |
cElementTree is a deprecated alias for ElementTree since Python 3.3. As we are now supporting only Python ≥ 3.5, we do not need to use it.
The version check is also no longer needed. The module has version 1.3.0 since 2010, so even Python 2.7 and 3.2 have it (see python/cpython@f15351d938e76c4b).