Skip to content
This repository was archived by the owner on Dec 22, 2023. It is now read-only.

Conversation

@CaptainRoberts
Copy link

@CaptainRoberts CaptainRoberts commented Oct 3, 2020

Description

I have an Amazon Web Scraper that gets all the a product has based on the item search URL provided that I wish to share in your repo.

Type of change

Choosing one or more options from the following as per the nature of your Pull request.

  • NOTE: These boxes can be checked using [X]

  • Bug fix (non-breaking change which fixes an issue)

  • New feature (non-breaking change which adds functionality)

  • Documentation Update

Checklist:

Please tick all the boxes that are fulfilled by your Pull Request.

  • I have named my files and folder, according to this project's guidelines.
  • My code follows the style guidelines of this project.
  • My Pull Request has a descriptive title. (not a vague title like Update index.md)
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have created a helpful and easy to understand README.md, according to the given README_TEMPLATE.
  • I have included a requirements.txt file (if external libraries are required.)
  • My changes do not produce any warnings.
  • I have added a working sample/screenshot of the script.

@@ -0,0 +1,2 @@
requests
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add specific version for used module and packages

use freeze list in your virtual environment to create requirements.txt file

pip freeze list>requirements.txt

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated it. Thanks for the suggestion @chavarera

Copy link
Member

@AdityaJ7 AdityaJ7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice Job Captain

@AdityaJ7
Copy link
Member

AdityaJ7 commented Oct 3, 2020

@all-contributors please add @CaptainRoberts for code

@mergify mergify bot merged commit c58e180 into Python-World:master Oct 3, 2020
@allcontributors
Copy link
Contributor

@AdityaJ7

I've put up a pull request to add @CaptainRoberts! 🎉

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants