This repository was archived by the owner on May 25, 2022. It is now read-only.
Send_email_from_CSV: Update with proper email library, etc#296
Merged
AdityaJ7 merged 5 commits intoOct 2, 2020
Conversation
Use snake_case for regular identifiers; restructure imports slightly
RFC5322 generally has the colon immediately adjacent to the header
Replace the basically empty file with a description etc
…Message Don't teach the young ones to glue together SMTP messages from simple strings; it's ugly and brittle. Instead, basically copy code from Python's email module documentation
Also requires the `email` module now
AdityaJ7
approved these changes
Oct 2, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This updates the code, and switches to using the
emailmodule from the standard library instead of the brittle and error-prone string pasting in the original.Also, this adds a proper README with instructions and notes.
Type of change
Choosing one or more options from the following as per the nature of your Pull request.
Checklist:
Please tick all the boxes that are fulfilled by your Pull Request.
Update index.md)README.md, according to the givenREADME_TEMPLATE.