Skip to content
This repository was archived by the owner on May 25, 2022. It is now read-only.

Conversation

@IngoKl
Copy link

@IngoKl IngoKl commented Jul 13, 2020

My attempt at Issue #77

@chavarera
Copy link
Member

@IngoKl

Please modify code with pep8 guidelines

Add code to handle false inputs

./cli.py:1:1: F401 'logging' imported but unused
./cli.py:4:1: F401 'proxytest.test_file' imported but unused
./cli.py:6:1: E302 expected 2 blank lines, found 1
./cli.py:10:1: E302 expected 2 blank lines, found 1
./cli.py:12:80: E501 line too long (88 > 79 characters)
./cli.py:17:1: E302 expected 2 blank lines, found 1
./cli.py:19:80: E501 line too long (88 > 79 characters)
./cli.py:21:5: F821 undefined name 'test_csv_file'
./cli.py:23:1: E302 expected 2 blank lines, found 1
./cli.py:25:80: E501 line too long (88 > 79 characters)
./proxytest.py:15:80: E501 line too long (106 > 79 characters)
./proxytest.py:26:37: E201 whitespace after '['
./proxytest.py:26:80: E501 line too long (155 > 79 characters)
./proxytest.py:28:34: E201 whitespace after '['
./proxytest.py:28:80: E501 line too long (189 > 79 characters)
./proxytest.py:28:146: E203 whitespace before ','
./proxytest.py:33:1: W293 blank line contains whitespace
./proxytest.py:34:5: E303 too many blank lines (2)
./proxytest.py:40:80: E501 line too long (97 > 79 characters)
./proxytest.py:51:1: W293 blank line contains whitespace
./proxytest.py:55:80: E501 line too long (84 > 79 characters)
./proxytest.py:63:80: E501 line too long (99 > 79 characters)
./proxytest.py:87:80: E501 line too long (87 > 79 characters)
./proxytest.py:93:80: E501 line too long (80 > 79 characters)
./proxytest.py:100:80: E501 line too long (91 > 79 characters)

@IngoKl
Copy link
Author

IngoKl commented Jul 14, 2020

@chavarera Thank you for the feedback!

I've added basic input validation and increased PEP8 compliance (... I forgot that I had disabled Flake8). There are two >80 character issues left, but I'd suggest keeping it that way for the sake of readability.

@chavarera
Copy link
Member

Ok @IngoKl

@chavarera chavarera merged commit cb73efa into Python-World:master Jul 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants