Skip to content

Conversation

@aahnik
Copy link
Member

@aahnik aahnik commented Jul 1, 2021

GitHub automatically creates a GITHUB_TOKEN secret to use in your workflow. You can use the GITHUB_TOKEN to authenticate in a workflow run.

https://docs.github.com/en/actions/reference/authentication-in-a-workflow

@codecov-commenter
Copy link

codecov-commenter commented Jul 1, 2021

Codecov Report

Merging #14 (968d993) into main (d82fc38) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##            main     #14   +/-   ##
=====================================
  Coverage   1.60%   1.60%           
=====================================
  Files          6       6           
  Lines        125     125           
=====================================
  Hits           2       2           
  Misses       123     123           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d82fc38...968d993. Read the comment docs.

@aahnik
Copy link
Member Author

aahnik commented Jul 1, 2021

while running locally, you can

export GH_TOKEN=YOUR PERSONAL ACCESS TOKEN

to create PAT https://docs.github.com/en/github/authenticating-to-github/keeping-your-account-and-data-secure/creating-a-personal-access-token

although the export command will set it only for the current shell session.

we can put the export statement in .bashrc file or other files that your shell loads.

we may also use a .env file. We need to load the contents of .env using python-dotenv.

Once loaded the GH_TOKEN env var will be available to webdriver manager

# .env
GH_TOKEN=...

@aahnik aahnik requested a review from chavarera July 1, 2021 10:02
@aahnik
Copy link
Member Author

aahnik commented Jul 1, 2021

in github actions, from the same ip address, so the many tests run. 3*2 = 6 times in a short period of time. that's why so many requests to the apis. and rate limit is exceeded.

but when tests locally, its less likely to exceed rate limits

@aahnik
Copy link
Member Author

aahnik commented Jul 1, 2021

after seeing the source code of webdriver manager, I finally found this

https://github.com/SergeyPirogov/webdriver_manager/blob/ed0727738285e22767f7bb8b77c432566d31fccf/webdriver_manager/driver.py#L71

this is the part of the code, which deals with gh token.

@chavarera
Copy link
Member

@aahnik nice work

@chavarera chavarera merged commit ba5e673 into Python-World:main Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants