Merged
Conversation
- Use the old pass manager available through llvmlite 0.44 - Separate linking of libdevice and the openmp device RTL - Optimize with opt=2 with libdevice - Optimize with opt=1 with device RTL to avoid miscompilation and openmp synchronization errors
- Pass original values to copy as pointers to avoid ABI issues
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the OpenMP CUDA codegen pipeline and LLVM pass/lowering logic to improve correctness and stability for GPU target offloading.
Changes:
- Split device bitcode linking into two stages (libdevice first, then OpenMP device RTL) with separate optimization passes.
- Switch from the “new” pass manager usage to legacy pass manager builder/population for function/module passes.
- Simplify firstprivate handling in the OpenMP intrinsic lowering pass by removing the previous Int64 byval workaround and consistently passing captured values by their native types.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
src/numba/openmp/omp_ir.py |
Refactors CUDA target image generation: staged bitcode linking + legacy pass manager population and adjusted opt levels. |
src/numba/openmp/libs/pass/CGIntrinsicsOpenMP.cpp |
Simplifies firstprivate argument typing/passing and updates outlined function argument handling accordingly. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.