feat: add device name to logs #100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
humbertogontijo
approved these changes
Jul 31, 2023
Collaborator
humbertogontijo
left a comment
humbertogontijo
left a comment
There was a problem hiding this comment.
I wonder if using the device id is worth, cause the device names could be the same.
Anyway, this will help with the existing issues
Collaborator
Author
|
I thought the same thing, but the device ids are so long that I thought it would be much easier to understand if it was with device name. The user can always change their vacuums name if needed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes logs like this so that we can more easily identify what logsare coming from what vacuum when there are multiple devices on an account.