fix: update listeners #140
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lash-L
commented
Nov 6, 2023
Collaborator
Author
|
Made a few changes to get it to work well, good to go as long as you agree with it |
Collaborator
Author
|
Tested having a missing key - and I realized the missing function of RoborockEnum was going to automatically make it not raise a valueerror. So I overroad it for this enum. Now it should be good haah - one more approval please |
humbertogontijo
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My thought here was that it is global, but we would be able to just call functions that are affected by this value change. i.e. just update the error sensor when we get an error instead of updating all of our entitites.
Thoughts?