Skip to content

fix: don't wait for the mqtt thread to fully shutdown when disconecting. #309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix: don't wait for the mqtt thread to fully shutdown when disconecting. #309

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion roborock/cloud_api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,8 @@ async def async_disconnect(self) -> None:
if disconnected_future := self._sync_disconnect():
# There are no errors set on this future
await disconnected_future
await self.event_loop.run_in_executor(None, self._mqtt_client.loop_stop)
# Stop the loop but don't wait for it to fully shutdown
self.event_loop.run_in_executor(None, self._mqtt_client.loop_stop)

async def async_connect(self) -> None:
async with self._mutex:
Expand Down
Loading