-
Notifications
You must be signed in to change notification settings - Fork 52
Clean summary for old devices #39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
On humbertogontijo/homeassistant-roborock#245 @tobiasbrage added a log |
|
I have had same output also. You can see it in this issue humbertogontijo/homeassistant-roborock#117 (comment) I don't know why it previously only reported int and now list but I'm pretty sure that summary works for @tobiasbrage with this change. |
|
@humbertogontijo Is it possible that 0.1.2 reports clean_summary different way than main? Maybe that is reason why it previously was int and now list? @tobiasbrage Can you get log after updating main? |
|
Sure, hold on. |
|
@Dis90 Are you using offline mode in main? Could be that |
|
I still get the get_clean_summary output in the log after updating to main. 2023-04-21 16:59:57.332 DEBUG (MainThread) [roborock.api] id=5 Response from get_clean_summary: 172775 |
|
@humbertogontijo Nope. Local is not activated. @tobiasbrage Are you sure you're in main? My log displays [roborock.cloud_api] and yours [roborock.api] I have noticed that you have to wait little bit after choosing main before you click download. |
|
I'm in main. I have a couple of dock sensors that's only available in main. |
|
@tobiasbrage Do you have sensor for total clean time? |
|
No, sadly not. |
|
@humbertogontijo Any ideas why there's difference in logs [roborock.cloud_api] vs [roborock.api] ? @tobiasbrage Can you verify integration version from file /config/custom_components/roborock/manifest.json |
|
It looks like a firmware change. @Dis90 have you updated your vacuum between humbertogontijo/homeassistant-roborock#117 (comment) and now? |
|
@humbertogontijo I'm almost 100 % sure that I haven't updated vacuum. |
|
@Dis90 and @tobiasbrage I did the changes from this PR and updated the main branch for the HA integration. Could you guys check? |
|
@humbertogontijo dude, you're f***ing awesome! I now have a total cleaning sensor. Awesome work, thank you! 🙌 |
|
Yep works now :) |
|
@Dis90 I have 22 entities in total. I have total area cleaned, total time cleaned as well as total number of cleanings. :) |
|
@humbertogontijo You can delete validation for int. |
Example output of get_clean_summary
2023-04-20 16:59:31.631 DEBUG (MainThread) [roborock.cloud_api] id=44374 Response from get_clean_summary: [297526, 4309707500, 260, [1681952400, 1681866001, 1681779601, 1681693200, 1681645328, 1681641905, 1681606801, 1681520401, 1681434001, 1681347601, 1681261201, 1681174801, 1681088401, 1681002002, 1680915601, 1680829200, 1680742801, 1680656401, 1680570001, 1680483600]]Values are 297526=Total Time in seconds, 4309707500=Total Area, 260=Cycles
Fixes: humbertogontijo/homeassistant-roborock#245 and humbertogontijo/homeassistant-roborock#117