Skip to content

Conversation

@Lash-L
Copy link
Collaborator

@Lash-L Lash-L commented Apr 27, 2023

Added a check if it is missing, return "UNKNOWN" which is now on all enums, but does not show up in lists.

Thoughts?

@Lash-L
Copy link
Collaborator Author

Lash-L commented Apr 27, 2023

code_mappings is where my code changes are, the rest is just reverted code

@humbertogontijo
Copy link
Collaborator

humbertogontijo commented Apr 27, 2023

It's late for me, but I'll try this out as soon as I can. I still feel like if this value is 207 it still throw an error cus the vacuum will not recognize it. But I'll try it out.
Anyway, this might be better then making the integration useless

@Lash-L
Copy link
Collaborator Author

Lash-L commented Apr 28, 2023

It's late for me, but I'll try this out as soon as I can. I still feel like if this value is 207 it still throw an error cus the vacuum will not recognize it. But I'll try it out.
Anyway, this might be better then making the integration useless

I'm surprised we haven't run into this before. But I guess with the new enum system, winces it's just on main, no one with an s6 maxv has tried it?

Look at my test in test container that was my proof of concept

@humbertogontijo humbertogontijo merged commit 49d77f8 into Python-roborock:main Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants